Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AdminSettings): server buttons visual interactivity #12814

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jul 25, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
before after

🚧 Tasks

  • Replace tertiary-no-background -> tertiary
    • Recording server - delete
    • Signaling server - delete
    • STUN server - delete (+ add a missing gap here)
    • TURN server - delete + test.
  • Prevent infinite loading in TURN server testing
    • Don't switch to "testing" (loading) state if testing is not happening
      image
    • Disable the testing button when testing is not possible
      image
  • Align turn settings on center to avoid button stretch
    Before After
    image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@ShGKme ShGKme added 3. to review design feature: settings ⚙️ Settings and config related issues feature: frontend 🖌️ "Web UI" client labels Jul 25, 2024
@ShGKme ShGKme added this to the 💙 Next Major (30) milestone Jul 25, 2024
@ShGKme ShGKme requested a review from Antreesy July 25, 2024 09:48
@ShGKme ShGKme self-assigned this Jul 25, 2024
@Antreesy Antreesy force-pushed the fix/admin-settings--stun-server-buttons-ui branch from 3c48e24 to 4a85d2e Compare July 26, 2024 11:23
- replace tertiary-no-background with tertiary

Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme marked this pull request as draft July 29, 2024 08:42
@ShGKme ShGKme force-pushed the fix/admin-settings--stun-server-buttons-ui branch from 4a85d2e to b92c10f Compare July 29, 2024 09:35
@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 29, 2024

  • Rebased onto main
  • Fixed button stretch issue

@ShGKme ShGKme marked this pull request as ready for review July 29, 2024 09:35
@Antreesy Antreesy merged commit deac531 into main Jul 29, 2024
48 checks passed
@Antreesy Antreesy deleted the fix/admin-settings--stun-server-buttons-ui branch July 29, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants