Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MediaSettings): remove PiP and increase mirror toggle margin #12838

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jul 29, 2024

☑️ Resolves

  • Minor UI changes:
    • Remove Picture-In-Picture
      • It must be exactly disablePictureInPicture, it cannot be disable-picture-in-picture
    • Use base * 2 padding for the toggle button
      • Inline with other paddings on the modal

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy merged commit 3252d03 into main Jul 29, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/media-settings-minor-changes branch July 29, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants