Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(signaling): check only required features on Frontend #13078

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix(signaling): check only required features on Frontend #13078

merged 1 commit into from
Aug 22, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 21, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Tested with Talk 19 on Talk Desktop (20 frontend)

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Check a signaling server feature only if corresponding capability is available

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@ShGKme ShGKme added this to the 🖤 Next Major (31) milestone Aug 21, 2024
@ShGKme ShGKme self-assigned this Aug 21, 2024
@ShGKme ShGKme marked this pull request as ready for review August 22, 2024 12:54
Antreesy
Antreesy reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't test

@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 22, 2024

/backport to stable30

@ShGKme ShGKme merged commit 818b065 into main Aug 22, 2024
48 checks passed
@ShGKme ShGKme deleted the fix/check-only-needed-signaling-features branch August 22, 2024 13:11
@backportbot backportbot bot mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@ShGKme ShGKme

Labels
2. developing bug client: 💻 desktop feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.

Nextcloud talk always reports the signaling server needs upgrading.
2 participants
@ShGKme @Antreesy