Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable30] fix(signaling): check only required features on Frontend #13094

Merged
merged 1 commit into from
Aug 22, 2024
Merged

[stable30] fix(signaling): check only required features on Frontend #13094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/utils/signaling.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {

import CancelableRequest from './cancelableRequest.js'
import { PARTICIPANT } from '../constants.js'
import { hasTalkFeature } from '../services/CapabilitiesManager.ts'
import { EventBus } from '../services/EventBus.js'
import { rejoinConversation } from '../services/participantsService.js'
import { pullSignalingMessages } from '../services/signalingService.js'
Expand Down Expand Up @@ -1082,10 +1083,12 @@ Signaling.Standalone.prototype.helloResponseReceived = function(data) {
}

if (!this.settings.helloAuthParams.internal
&& (!this.hasFeature('audio-video-permissions')
|| !this.hasFeature('federation')
|| !this.hasFeature('incall-all')
|| !this.hasFeature('switchto'))) {
&& ((!this.hasFeature('audio-video-permissions') && hasTalkFeature('local', 'conversation-permissions')) // Talk v13
|| !this.hasFeature('incall-all') // Talk v15
|| (!this.hasFeature('switchto') && hasTalkFeature('local', 'breakout-rooms-v1')) // Talk v16
|| (!this.hasFeature('federation') && hasTalkFeature('local', 'federation-v2')) // Talk v20
)
) {
showError(
t('spreed', 'The configured signaling server needs to be updated to be compatible with this version of Talk. Please contact your administration.'),
{
Expand Down
Loading