Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't remove LeftSidebar in fullscreen mode, but hide it #13310

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix: don't remove LeftSidebar in fullscreen mode, but hide it #13310

merged 1 commit into from
Sep 16, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix disappearing sidebar in fullcreenmode
    • Initial commit to remove it was made before AppNavigation has a toggle button
    • Now it's possible to hide it, but keep available to open back => proceed that way

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Sep 15, 2024
@Antreesy Antreesy self-assigned this Sep 15, 2024
DorraJaouad
DorraJaouad approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, no issues

@Antreesy Antreesy merged commit 8735399 into main Sep 16, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/fullscreen-leftsidebar branch September 16, 2024 13:14
@Antreesy
Copy link
Contributor Author

/backport to stable30

@backportbot backportbot bot mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@Antreesy Antreesy

Labels
3. to review design enhancement feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
4 participants
@Antreesy @ShGKme @marcoambrosini @DorraJaouad