Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove mainContainerSelector and uiModeStore #13341

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 19, 2024

☑️ Resolves

  • Follow-up to fullscreen refactoring

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client

@Antreesy Antreesy marked this pull request as ready for review September 19, 2024 13:12
@Antreesy Antreesy changed the title fix: remove mainContainerSelector store fix: remove mainContainerSelector and uiModeStore Sep 19, 2024
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, looked through all 50 files, thanks a lot!

@Antreesy Antreesy merged commit e15d7db into main Sep 19, 2024
48 checks passed
@Antreesy Antreesy deleted the fix/noid/fullscreen-cleanup branch September 19, 2024 15:11
@Antreesy
Copy link
Contributor Author

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants