Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hpb): Deprecate multiple HPBs and fake-clustering #13401

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 26, 2024

☑️ Resolves

This PR here will be backported.

Main-only follow up will be done to:

  • Always use the first HPB
  • Remove the conversation_clustering appconfig
  • Remove UI option at add additional ones
  • Throw on OCC command when trying to add additional ones
  • Make the setup check an error

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: signaling 📶 Internal and external signaling backends labels Sep 26, 2024
@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Sep 26, 2024
@nickvergessen nickvergessen self-assigned this Sep 26, 2024
@nickvergessen
Copy link
Member Author

/backport to stable30

Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine (and happy xD) to deprecated the conversation_cluster mode.

But I am not sure about forcing a single signaling server. If an HPB cluster is used, is it expected that a single signaling server is used in Talk? Or would it be possible to set up several signaling servers, so each participant ends in a random one, and then the signaling servers take care of exchanging the messages between them as needed?

The idea with that would be to avoid having a single point of failure in the signaling server cluster. @fancycode Could you clarify that? Thanks!

@nickvergessen
Copy link
Member Author

If an HPB cluster is used, is it expected that a single signaling server is used in Talk?

Yes, that is what Jojo told me. You would specify a proxy in Talk in that case and that would take care of automatically load balancing

@fancycode
Copy link
Member

If an HPB cluster is used, is it expected that a single signaling server is used in Talk?

Yes, that is what Jojo told me. You would specify a proxy in Talk in that case and that would take care of automatically load balancing

Right, the load-balancer in front can easily determine which signaling server(s) are available and distribute the requests across them. Having a list in Talk would require to also implement the checks there and handle all sorts of cases if the list of available servers changes (i.e. how to notify clients to now use a different server, etc.).

@fancycode
Copy link
Member

The idea with that would be to avoid having a single point of failure in the signaling server cluster. @fancycode Could you clarify that? Thanks!

Of course the load-balancer / proxy in front should be setup so that it's redundant / highly-available. But this is out of scope for Talk or the signaling server. If your setup is so large that you need a clustered signaling server, you should have ways to run a HA frontend proxy / load balancer.

Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fancycode Thanks for the information!

Copy link
Member

@fancycode fancycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a wording suggestion

lib/SetupCheck/HighPerformanceBackend.php Outdated Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the bugfix/13011/deprecate-multiple-hpbs branch from cb4bdff to cfb72e0 Compare September 30, 2024 12:07
@nickvergessen nickvergessen merged commit 9fcec3c into main Sep 30, 2024
68 checks passed
@nickvergessen nickvergessen deleted the bugfix/13011/deprecate-multiple-hpbs branch September 30, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: signaling 📶 Internal and external signaling backends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate "clustered HPB" mode
3 participants