Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some translation calls #13408

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Fix some translation calls #13408

merged 1 commit into from
Sep 27, 2024

Conversation

Jerome-Herbinet
Copy link
Member

@Jerome-Herbinet Jerome-Herbinet commented Sep 27, 2024 •
edited by Antreesy
Loading

☑️ Resolves

  • 'settings' translations are not loaded in 'spreed' page

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image Screenshot after

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Antreesy
Antreesy approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense 🙈 Thanks for noticing!

@Antreesy Antreesy force-pushed the Jerome-Herbinet-fix-some-translation-calls branch from bbb7f97 to ed0dc66 Compare September 27, 2024 07:30
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Sep 27, 2024
@Antreesy Antreesy merged commit ab396ab into main Sep 27, 2024
46 checks passed
@Antreesy Antreesy deleted the Jerome-Herbinet-fix-some-translation-calls branch September 27, 2024 07:59
@Antreesy
Copy link
Contributor

/backport to stable30

@Antreesy
Copy link
Contributor

/backport to stable29

@Antreesy
Copy link
Contributor

/backport to stable28

@backportbot backportbot bot mentioned this pull request Sep 27, 2024
Merged
This was referenced Sep 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees
No one assigned
Labels
3. to review bug feature: settings ⚙️ Settings and config related issues papercut
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
2 participants
@Jerome-Herbinet @Antreesy