-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MessagesList): update date separator overnight #13425
Conversation
/backport to stable30 |
/backport to stable29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After private discussion:
- move logic to
onWindowFocus()
- use
Vue.set()
to ensure update is reactive - use
:key="dateSeparatorLabels[dateTimestamp]"
in template if won't update without it
Tried that way, requires 1 minute for browser to grab a changed system time, then click on window trigger re-render
e0f8c2e
to
a7fab80
Compare
a7fab80
to
e891b84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working after locking/unlocking the screen, as demanded.
Check linter and merge =)
Signed-off-by: DorraJaouad <[email protected]>
e891b84
to
f91e5dd
Compare
Why? |
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist