[stable22.1] Fix container of modal and popup components when Talk is embedded #6155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
The container of modal and popup components was always set to "#content-vue" to ensure that they will be properly shown in normal and fullscreen mode in the main Talk UI. However, when Talk is embedded in the Files app, the share page or the video verification there is no such element, so the container for the components could not be set and thus they were not shown. To solve this now the selector for the main container element is got from the store instead of being hardcoded, and the different UI modes set the appropriate value when initialized (or leave it undefined to use the default one, typically the body element, when a specific element is not needed). Note that this change applies too to some components that, right now, are only shown in the main Talk UI, but it was done for consistency and to make them "future-proof". Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Using the default container causes the action menus in the Talk tab to be repositioned at wrong places when the menus are shown and the file list is scrolled. To address this (although it does not fully fix the issue, there are still some strange behaviours) the main container for Talk components used when Talk is embedded in the Files app is Talk tab. Besides that, both the container and the boundaries element of the actions are set to the Talk tab. Despite setting the main container this change does not affect other components (like the room selector) or slightly improves their behaviour (like the author avatar menu, which no longer appears outside the tab when scrolling). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
backportbot-nextcloud
bot
added
bug
feature: frontend 🖌️
backportbot-nextcloud
bot
requested review from
danxuliu,
marcoambrosini and
nickvergessen
nickvergessen
approved these changes
Aug 27, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #6119