fix: notifications link for mobile / desktop error generating errors in v30

[joshtrichards]

Fixes #316

EDIT: I guess this has been broken for awhile, but wasn't super apparent until the new notification logging added in nextcloud/server#44770

[joshtrichards]

/backport to stable30

[nickvergessen]

Will fix tomorrow

[nickvergessen]

/backport to stable30

[nickvergessen]

/backport to stable29

[nickvergessen]

/backport to stable28

[joshtrichards]

Thanks for bringing the URL generation up-to-date, @nickvergessen. Looks like I did it the old way.

[La-Fabrique-Info]

Warnings are still happening... doesn't seem fixed for me.
NC Version: 30.0.0.14
survey_client version: 2.0.0

{
    "reqId": "QYss6puhYbfWtBEO2goJ",
    "level": 2,
    "time": "2024-09-28T10:22:53+00:00",
    "remoteAddr": "********",
    "user": "*******",
    "app": "no app in context",
    "method": "GET",
    "url": "/ocs/v2.php/apps/notifications/api/v2/notifications",
    "message": "Icon of notification is not an absolute URL and does not work in mobile and desktop clients [app: survey_client, subject: updated]",
    "userAgent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36",
    "version": "30.0.0.14",
    "data": [],
    "id": "66f7d914e838a"
}

[joshtrichards]

Well, yeah - the code was just merged. :) You have to wait until the next maintenance release (or apply it manually early if you're into that sort of thing: https://docs.nextcloud.com/server/latest/admin_manual/issues/applying_patch.html)

[La-Fabrique-Info]

Sorry for not having mentioned it in my previous message but the modif file lib/BackgroundJobs/AdminNotification.php has been patched in my setup.

[nickvergessen]

We didn't fix the icon. I can do it Monday.
Thanks for reporting back!