Support delete-multiple push notification #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
enhancement
app/src/gplay/java/com/nextcloud/talk/services/firebase/MagicFirebaseMessagingService.kt
Outdated
Show resolved
Hide resolved
nickvergessen
force-pushed
the
support-delete-multiple
branch
from
51e35fe
to
d5cca71
Compare
AndyScherzinger
force-pushed
the
support-delete-multiple
branch
3 times, most recently
from
4e00681
to
bc374ad
Compare
AndyScherzinger
approved these changes
Apr 21, 2021
Closed
2 tasks
AndyScherzinger
force-pushed
the
support-delete-multiple
branch
from
bc374ad
to
80d3960
Compare
app/src/gplay/java/com/nextcloud/talk/services/firebase/MagicFirebaseMessagingService.kt
Show resolved
Hide resolved
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
AndyScherzinger
force-pushed
the
support-delete-multiple
branch
from
80d3960
to
5c26a0c
Compare
|
@nickvergessen any info how this can be tested? :) |
|
It could be tested with nextcloud/notifications#939 |
Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/1142-talk.apk |
AndyScherzinger
approved these changes
Apr 30, 2021
… [skip ci] Signed-off-by: Andy Scherzinger <[email protected]>
AndyScherzinger
force-pushed
the
support-delete-multiple
branch
from
04ce71f
to
c81a272
Compare
Lint
SpotBugs (new)
SpotBugs (master)
|
mahibi
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🦯 (blind) coding here. I still fail to compile and run the app locally and sending push notifications also is rather troublesome locally.
Also I don't know kotlin and googled the foreach of java, but I want to help moving forward to fix a problem with dying push notifications in iOS by implementing nextcloud/notifications#936