Harden check when using token from memcache #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly comparing never hurt anybody. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
harden/memcachetokenfetching
branch
from
68ad904
to
57ab100
Compare
|
/backport to stable19 |
|
/backport to stable18 |
|
/backport to stable17 |
juliushaertl
approved these changes
Sep 7, 2020
|
The backport to stable18 failed. Please do this backport manually. |
|
The backport to stable17 failed. Please do this backport manually. |
|
Session cache is only available starting with Nextcloud 19 #761 |
|
@rullzer It might make sense to also backport that one, any opinions? |
🙄 |
|
Not urgently needed, so I'd say we skip this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly comparing never hurt anybody.