Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix headlines being hidden behind toolbar (anchor links) #2862

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 5, 2022

Summary

This adds a scroll margin to the target elements when using the anchor links to scroll to an element.
Fixing an issue where the heading is hidden behind the toolbar.

@susnux susnux requested a review from mejo- September 5, 2022 14:19
@susnux susnux added bug Something isn't working 3. to review labels Sep 5, 2022
@susnux
Copy link
Contributor Author

susnux commented Sep 5, 2022

/compile amend

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I wonder if this also fixed the failing cypress test.

@max-nextcloud
Copy link
Collaborator

/rebase

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anchor links: headlines hidden behind toolbar
2 participants