Fix focus becoming impossible to get after escape pressed in the link picker modal #3770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #8544 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
max-nextcloud
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
I was not able to reproduce the behavior described as without this fix escape would close the entire viewer for me. Maybe I'm running an outdated server or viewer version.
With this fix the behavior seems correct.
Code changes seem reasonable as well. Thanks 🎉
julien-nc
force-pushed
the
fix/noid/link-picker-focus-issue
branch
from
af04d35
to
470fb23
Compare
|
/compile |
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
fix/noid/link-picker-focus-issue
branch
from
f2e47d9
to
5217a6c
Compare
|
/compile |
juliushaertl
approved these changes
Feb 8, 2023
Signed-off-by: nextcloud-command <[email protected]>
This was referenced Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires nextcloud-libraries/vue-richtext#897 (will most likely be included in the next vue-richtext release)
We can now tell the link picker when it is created while the Viewer is displayed so an event is emitted to deal with the focus trap issue.