Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich workspace polishing #5021

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Rich workspace polishing #5021

merged 4 commits into from
Nov 23, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Nov 22, 2023

While trying to quickly implement #5018 I noticed a few quirks around rich workspaces and ended up digging deeper, so this is a combination of richworkspace fixes for 28

  • fix: Avoid having multiple rich workspace instances active
    • I noticed that text sessions from richworkspaces where still continuing to issue requests after switching folders. It turned out that the F2V way of rendering the headers will call render on every folder change, but not on empty folders. Therefore we cannot reuse an already created vue instance for the rich workspace and need to make sure to destroy it properly before rendering a new one.
  • fix: Keep track of local state of the rich workspace separately
    • If felt cleaner to not reuse the showRichWorkspace/hideRichWorkspace methods since they are explicitly for toggling the setting, so i use a local state that is initialized with the prop value but may be changed afterwards through creating/deleting/renaming a README file
  • fix: Make loading of rich workspace pixel perfect
    • The read only editor has a global server css margin which caused a minor 3px jump, now with this commit the switch between preview and text session is not noticable
  • fix: Remove minimum height to only use needed space
    • Actual fix I wanted to do 🙈

📝 Summary

@juliushaertl juliushaertl added bug Something isn't working 3. to review labels Nov 22, 2023
@juliushaertl juliushaertl added this to the Nextcloud 28 milestone Nov 22, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@juliushaertl juliushaertl merged commit 6e9b1fd into main Nov 23, 2023
35 checks passed
@juliushaertl juliushaertl deleted the bugfix/5018 branch November 23, 2023 19:43
@juliushaertl
Copy link
Member Author

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rich workspaces takes too much screen estate when Readme.md is empty
3 participants