fix: Use our own vue instance rendering anything but the viewer component #5547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5531
This is a slightly different approach from #5402 which i haven't managed to propagate through all layers of tiptaps vue renderer. As far as I could see this seems to work fine without any logged errors and kind of isolates any Vue usage in text to use our own Vue constructor.
I'm not sure this is the best approach and technically also not as clean, but given we want to fix the broken interactive previews the best I could come up for now. Ideally I would love to actually fully isolate text from the viewer itself in terms of their vue components, but that is likely a larger task and not feasible to fix the bug for the 29 release for now.