Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] fix(paragraph): migrate preview options to decorations #6431

Merged
merged 13 commits into from
Sep 23, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 19, 2024

Backport of #6425

max-nextcloud and others added 12 commits September 23, 2024 12:53
Render the preview options as a decoration for previews too.

Signed-off-by: Max <[email protected]>
Compute the range based on offset and nodeSize.

Signed-off-by: Max <[email protected]>
- center align options for text links
- top align options for preview links

Signed-off-by: Jonas <[email protected]>
Otherwise the overlay container would catch all the click events.

Signed-off-by: Jonas <[email protected]>
* Don't calculate preview options decorations in readonly editor
* Check for changed nodeSize when checking for decoration changes
* Rename `editor` to `$editor` in vue compontent, it's not reactive

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- marked this pull request as ready for review September 23, 2024 11:38
@mejo- mejo- merged commit 01b6178 into stable30 Sep 23, 2024
63 checks passed
@mejo- mejo- deleted the backport/6425/stable30 branch September 23, 2024 14:19
@Altahrim Altahrim mentioned this pull request Oct 1, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants