Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(integrity): do not expect ocm-provider anymore #506

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Oct 5, 2023

The ocm-provider dir was removed in 26.0.8 and 27.1.2.

@blizzz blizzz added this to the Nextcloud 28 milestone Oct 5, 2023
@blizzz
Copy link
Member Author

blizzz commented Oct 5, 2023

test needs updates… the stable ones fail of course.

@blizzz
Copy link
Member Author

blizzz commented Nov 9, 2023

I removed now all non-master tests…

@blizzz

This comment was marked as resolved.

@blizzz blizzz force-pushed the enh/noid/do-not-expect-ocm-provider branch from ba6e3ac to b10ed0d Compare November 9, 2023 11:49
@blizzz blizzz force-pushed the enh/noid/do-not-expect-ocm-provider branch from 0aa8187 to bd9e433 Compare November 9, 2023 11:53
Copy link
Collaborator

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing all tests?

@blizzz
Copy link
Member Author

blizzz commented Nov 9, 2023

Why are you removing all tests?

I am removing tests against NC 24 to 26, because they are failing due to presence of the ocm-provider file (https://github.com/nextcloud/updater/actions/runs/6417991835/job/17424862460, https://github.com/nextcloud/updater/actions/runs/6417991840/job/17424861208).

Screenshot_20231109_203639

This updater branch runs in reality on 28 only, therefore the tests against the old versions were already suspicious and may give you a wrong picture of both expectations and results.

@come-nc
Copy link
Collaborator

come-nc commented Nov 13, 2023

Why are you removing all tests?

I am removing tests against NC 24 to 26, because they are failing due to presence of the ocm-provider file (https://github.com/nextcloud/updater/actions/runs/6417991835/job/17424862460, https://github.com/nextcloud/updater/actions/runs/6417991840/job/17424861208).

Screenshot_20231109_203639

This updater branch runs in reality on 28 only, therefore the tests against the old versions were already suspicious and may give you a wrong picture of both expectations and results.

But these tests are testing the updater in several scenarios, such as beta versions, minor versions, wrong signature, and so on and so on.
You can read the feature files to get the list: https://github.com/nextcloud/updater/tree/master/tests/features

If you merge this the only test remaining is updating from master branch to master branch which only happens on developer setups and none of the productions scenarios are tested anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants