Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup app bootstrap #611

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Cleanup app bootstrap #611

wants to merge 1 commit into from

Conversation

CarlSchwan
Copy link
Member

Remove a bunch of deprecated stuff

@CarlSchwan CarlSchwan self-assigned this May 9, 2022
@CarlSchwan CarlSchwan marked this pull request as draft May 9, 2022 10:52
@CarlSchwan CarlSchwan force-pushed the cleanup/app-boostrap branch 3 times, most recently from d741067 to ac67e50 Compare May 9, 2022 11:10
@@ -21,14 +21,38 @@

namespace OCA\User_SAML\AppInfo;

use OC;
use OC\Security\CSRF\CsrfTokenManager;
use OC_User;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private?

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 91 lines in your changes are missing coverage. Please review.

Comparison is base (b366dfd) 0.00% compared to head (4a74f78) 22.51%.
Report is 181 commits behind head on master.

❗ Current head 4a74f78 differs from pull request most recent head f05f999. Consider uploading reports for the commit f05f999 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #611       +/-   ##
=============================================
+ Coverage      0.00%   22.51%   +22.51%     
- Complexity      361      379       +18     
=============================================
  Files            23       22        -1     
  Lines          1704     1426      -278     
=============================================
+ Hits              0      321      +321     
+ Misses         1704     1105      -599     
Files Coverage Δ
lib/UserBackend.php 29.02% <ø> (+29.02%) ⬆️
lib/AppInfo/Application.php 15.00% <1.08%> (+15.00%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliusknorr
Copy link
Member

juliusknorr commented Oct 26, 2023

Just rebased, a few things left

  • Move script handling to event listener
  • Register middleware/service through register method
  • Checkout if other private methods can be replaced
  • registerDavAuth seems unused currently

Remove a bunch of deprecated stuff

Signed-off-by: Carl Schwan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants