Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting filenames containing numbers #1956

Closed
wants to merge 1 commit into from

Conversation

cooltyp100
Copy link
Contributor

Changes the sorting behavior for files with number in their names to be more natural, e.g.:

Current/Old behavior:

  • Picture 1.jpg
  • Picture 10.jpg
  • Picture 11.jpg
  • ...
  • Picture 19.jpg
  • Picture 2.jpg
  • Picture 20.jpg

New behavior:

  • Picture 1.jpg
  • Picture 2.jpg
  • ...
  • Picture 10.jpg
  • Picture 11.jpg
  • ...
  • Picture 20.jpg

Fixes #547

@skjnldsv skjnldsv added bug Something isn't working papercut Small issues that doesn't break the ux/ui 3. to review Waiting for reviews labels Sep 5, 2023
@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Sep 5, 2023
@skjnldsv skjnldsv requested review from a team, artonge, szaimen and sorbaugh and removed request for a team September 5, 2023 07:50
@skjnldsv
Copy link
Member

skjnldsv commented Sep 5, 2023

Related nextcloud-libraries/nextcloud-files#730
For Viewer 3.0 I think

@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@szaimen
Copy link
Contributor

szaimen commented Sep 19, 2023

Hi @cooltyp100 thanks for your PR! Can you please compile the assets and commit them here? Sorry for coming back to you so late!

@szaimen
Copy link
Contributor

szaimen commented Nov 30, 2023

Hi, sorry for taking so long! I just rebased this and created a new branch so that our normal workflows work: #2088

@szaimen szaimen closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feedback-requested papercut Small issues that doesn't break the ux/ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alphabetic sorting in Viewer is wrong with numbers
5 participants