Add heic image support

[steiny2k]

This is to add the viewer support for heic images. Given the backend is able to provide previews (jpegs) of the heic file through ImageMagick and libheif, this will enable the in-browser viewing of the files.

This addresses #4

Signed-off-by: Sebastian Steinmetz [email protected]

[skjnldsv]

Hey!
Thanks for this! This would be an incomplete support though, right?
Heic can contains a video inside or various other images, which won't be displayed here?

[steiny2k]

This would be an incomplete support though, right?

Exactly. It relies on ImageMagick and the core preview handling for doing the heavy lifting.

Heic can contains a video inside or various other images, which won't be displayed here?

Technically speaking you are right. As the examples by nokiatech show, there are a lot of things a HEIF container may contain: https://nokiatech.github.io/heif/examples.html.
However, my use-case (and the use-case of most of the people using nextcloud I would guess) is photos being shot with an Apple iPhone (since iPhone 7). And for that showing the jpeg preview would be good enough I would say.
If a user wants to see all the sub-images of the file it is necessary to open the file with a suitable piece of software (Apple Photos app could do it).

Of course, long term goal could be to use the JavaScript based heif decoder (https://github.com/nokiatech/heif/wiki/IV.-HEIF-Reader-JavaScript-Implementation) to show directly the heif files. But I don't know if this would be a better user experience in the end. And to be honest, I think it should be the operating systems' or the browsers' duty to support these new image file types natively. So we wouldn't have to worry about any of this.

[skjnldsv]

And to be honest, I think it should be the operating systems' or the browsers' duty to support these new image file types natively. So we wouldn't have to worry about any of this.

I concurr!

@jancborchardt you ok with this?

[jancborchardt]

However, my use-case (and the use-case of most of the people using nextcloud I would guess) is photos being shot with an Apple iPhone (since iPhone 7). And for that showing the jpeg preview would be good enough I would say.

Agree with this, yes. This is a good improvement which will already improve the experience a lot for most people using that format.

[steiny2k]

Okay, given the input from Jan, how do we proceed? I see several of the checks didn't pass. Could someone point me in the direction, what I have to adjust in order provide a mergeable pull request?

[skjnldsv]

Okay, given the input from Jan, how do we proceed? I see several of the checks didn't pass. Could someone point me in the direction, what I have to adjust in order provide a mergeable pull request?

Just rebase and we'll compile the files again :)
It's just because other changes were merged.
You can rebase to master and drop all the /js changes

[skjnldsv]

@steiny2k please rebase :)

[steiny2k]

I'm not so sure, I should just merge this here, since I think I did something wrong with the rebasing. Github mentions a lot of files which would have been changed. So I've created a new PR #577. If thinks it's cleaner to merge that one.

[skjnldsv]

I'm not so sure, I should just merge this here, since I think I did something wrong with the rebasing. Github mentions a lot of files which would have been changed. So I've created a new PR #577. If thinks it's cleaner to merge that one.

What command did you run?

[MorrisJobke]

Let's close this here in favor of #577