Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose mimetypes so apps can check upfront if a file can be opened #605

Merged
merged 2 commits into from
Sep 10, 2020
Merged

Expose mimetypes so apps can check upfront if a file can be opened #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07952ee
Expose mimetypes so apps can check upfront if a file can be opened
juliushaertl Sep 8, 2020
0c4735e
Bump bundles
juliushaertl Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions js/viewer-main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/viewer-main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

13 changes: 13 additions & 0 deletions src/services/Viewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@ import Videos from '../models/videos'
export default class Viewer {

#state;
#mimetypes;

constructor() {
this.#mimetypes = []
this.#state = {}
this.#state.file = ''
this.#state.files = []
Expand Down Expand Up @@ -74,6 +76,7 @@ export default class Viewer {
*/
registerHandler(handler) {
this.#state.handlers.push(handler)
this.#mimetypes.push.apply(this.#mimetypes, handler.mimes)
}

/**
Expand All @@ -86,6 +89,16 @@ export default class Viewer {
return this.#state.file
}

/**
* Get the supported mimetypes that can be opened with the viewer
*
* @memberof Viewer
* @returns {array} list of mimetype strings that the viewer can open
*/
get mimetypes() {
return this.#mimetypes
}

/**
* Open the path into the viewer
*
Expand Down