Do not validate Azure or GCP storage paths #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to AWS, Azure and GCP do not handle empty files and directories very well (because they aren't real!). This PR ignores them in the same manner as AWS S3 blob storage.
adamrtalbot
force-pushed
the
ignore_blob_storage_validation
branch
from
ec7dd94
to
e43d01f
Compare
nvnieuwk
approved these changes
Apr 30, 2024
|
Can you update the changelog in the meantime? |
Done now, want me to merge? |
|
Yeah you can go ahead! I'll release the fix tomorrow :) |
|
Anywhere good to write tests before I merge? |
|
You can add tests here: https://github.com/nextflow-io/nf-schema/blob/master/plugins/nf-schema/src/test/nextflow/validation/ValidateParametersTest.groovy (just some simple test with those paths suffices for now, I will expand this later when implementing the full support) |
|
See 4262965 for tests. Good to go now once tests have passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to AWS, Azure and GCP do not handle empty files and directories very well (because they aren't real!). This PR ignores them in the same manner as AWS S3 blob storage.
Should fix #16