Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jaxlib for evofr on linux/arm64 #171

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Update jaxlib for evofr on linux/arm64 #171

merged 1 commit into from
Jul 7, 2023

Conversation

joverlee521
Copy link
Contributor

Description of proposed changes

The latest release of evofr included updates to its dependencies that updated the minimum version for jaxlib.¹ I'm using the latest release of jaxlib available in the user forked repo since there's still no official pre-built binaries for linux/arm64.²

I did not realize this change was needed until I saw the "Validate Platform" job fail in the CI run³ that I triggered to update evofr to v0.1.20.

¹ blab/evofr@46f744b
² jax-ml/jax#7097
³ https://github.com/nextstrain/docker-base/actions/runs/5480222698

Testing

  • Checks pass

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(non-blocking)

I did not realize this change was needed until I saw the "Validate Platform" job fail in the CI run³ that I triggered to update evofr to v0.1.20.

I'm glad CI caught this, but still, it probably would have taken me some time to figure out that updating jaxlib is the solution since I'm not familiar with evofr.

I can't think of a good way to accommodate future occurrences, barring official pre-built binaries for linux/arm64. Maybe a note alongside the evofr installation hinting at a pinned jaxlib would help? This also applies to Augur's CVXOPT dependency, which is now pinned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a note alongside the evofr installation hinting at a pinned jaxlib would help?

Good idea! I added a note for our future selves in the latest commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if there was an option for pip to warn us if it's unable to install the latest version because it's unable to satisfy dependency requirements. I found some discussions in pypa/pip#10784 for potentially adding a new feature for warning on mismatched Python version requirements. However, I can't seem to find an existing option to avoid this silent downgrade 😞

@victorlin
Copy link
Member

Also, since this branch is based on a version of master prior to all the new build time improvements, it provides a fun comparison (n=1) between build times before those changes (2h 8m) and after (1h 6m)!

The latest release of evofr included updates to its dependencies that
updated the minimum version for jaxlib.¹ I'm using the latest release
of jaxlib available in the user forked repo since there's still no
official pre-built binaries for linux/arm64.²

I did not realize this change was needed until I saw the
"Validate Platform" job fail in the CI run³ that I triggered to update
evofr to v0.1.20. Added a note for our future selves to check the
jaxlib installation if we run into different versions of evofr on the
different platforms.

¹ blab/evofr@46f744b
² jax-ml/jax#7097
³ https://github.com/nextstrain/docker-base/actions/runs/5480222698
@joverlee521 joverlee521 merged commit b36cdca into master Jul 7, 2023
33 checks passed
@joverlee521 joverlee521 deleted the evofr-0.1.20 branch July 7, 2023 18:27
@joverlee521 joverlee521 mentioned this pull request Jul 17, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants