Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NXxpcs: On review of the equation for g2, the units are identical in numerator and denominator. The correct unit type for this is NX_DIMENSIONLESS. #1005

Closed
prjemian opened this issue Mar 3, 2022 · 1 comment · Fixed by #1008
Closed

NXxpcs: On review of the equation for g2, the units are identical in numerator and denominator. The correct unit type for this is NX_DIMENSIONLESS. #1005

prjemian opened this issue Mar 3, 2022 · 1 comment · Fixed by #1008
Assignees
@prjemian
Labels
task
Milestone
NXDL 2022.06

Comments

@prjemian
Copy link
Contributor

prjemian commented Mar 3, 2022

On review of the equation for g2, the units are identical in numerator and denominator. The correct unit type for this is NX_DIMENSIONLESS.

Originally posted by @prjemian in #982 (comment)
@prjemian prjemian mentioned this issue Mar 3, 2022
Open
@prjemian prjemian self-assigned this Mar 3, 2022
@prjemian prjemian added the task label Mar 3, 2022
@prjemian prjemian added this to the NXDL 2022.03 milestone Mar 3, 2022
prjemian added a commit that referenced this issue Mar 3, 2022
@prjemian
MNT #1005 change g2 unit type to NX_DIMENSIONLESS
a76802b
@prjemian prjemian mentioned this issue Mar 3, 2022
Merged
@prjemian
Copy link
Contributor Author

prjemian commented Mar 8, 2022

NeXus describes many types of units. See the current list here: https://manual.nexusformat.org/nxdl-types.html#unit-categories-allowed-in-nxdl-specifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prjemian prjemian

Labels
task
Projects
None yet
Milestone
NXDL 2022.06
Development

Successfully merging a pull request may close this issue.

change g2 unit type to NX_DIMENSIONLESS nexusformat/definitions
1 participant
@prjemian