Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing closing parentheses in rendering of suggested target of linkType #1192

Closed
PeterC-DLS opened this issue Sep 15, 2022 · 2 comments · Fixed by #1195
Closed

Missing closing parentheses in rendering of suggested target of linkType #1192

PeterC-DLS opened this issue Sep 15, 2022 · 2 comments · Fixed by #1195
Assignees
@prjemian
Labels
bug
Milestone
NXDL 2023.10

Comments

@PeterC-DLS
Copy link
Contributor

See for example, NXdata/energy and NXdata/absorbed_beam
@prjemian
Copy link
Contributor 

(bluesky_2022_3) prjemian@zap:~/.../NeXus/definitions$ git grep "suggested target"
dev_tools/docs/nxdl.py:                f"(suggested target: ``{node.get('target')}``"

@prjemian prjemian self-assigned this Sep 15, 2022
@prjemian prjemian added the bug label Sep 15, 2022
@prjemian prjemian added this to the NXDL 2023.06 milestone Sep 15, 2022
@prjemian
Copy link
Contributor

@PeterC-DLS Good catch!

prjemian added a commit that referenced this issue Sep 15, 2022
@prjemian
MNT #1192
f783cdb
@prjemian prjemian mentioned this issue Sep 15, 2022
Merged
@PeterC-DLS PeterC-DLS modified the milestones: NXDL 2023.06, NXDL 2023.10 Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prjemian prjemian

Labels
bug
Projects
None yet
Milestone
NXDL 2023.10
Development

Successfully merging a pull request may close this issue.

add closing parenthesis in "suggested target" text nexusformat/definitions
2 participants
@PeterC-DLS @prjemian