Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid units #1204

Closed
TLCFEM opened this issue Sep 21, 2022 · 3 comments · Fixed by #1205
Closed

Invalid units #1204

TLCFEM opened this issue Sep 21, 2022 · 3 comments · Fixed by #1205
Assignees
@prjemian
Labels
bug
Milestone
NXDL 2023.10

Comments

@TLCFEM
Copy link

TLCFEM commented Sep 21, 2022

definitions/contributed_definitions/NXxpcs.nxdl.xml

Line 195 in ea89964

<field name="delay_difference" type="NX_INT" units="NX_INT" minOccurs="0" maxOccurs="1">

units=NX_INT is not a valid token for dimensionality. Guess it shall be NX_COUNT or something else.
@prjemian prjemian self-assigned this Sep 27, 2022
@prjemian prjemian added this to the NXDL 2023.06 milestone Sep 27, 2022
@prjemian prjemian added the bug label Sep 27, 2022
@prjemian
Copy link
Contributor

prjemian commented Sep 27, 2022 •
edited
Loading

Thanks for reporting this! Yes, that's an oversight.NX_COUNT seems right, based on the docs.

prjemian added a commit that referenced this issue Sep 27, 2022
@prjemian
MNT #1204
cd2e573
@prjemian prjemian mentioned this issue Sep 27, 2022
Merged
@PeterC-DLS
Copy link
Contributor

Also G2_unnormalized on L180 should not be dimensionless but NX_ANY

@prjemian
Copy link
Contributor

@PeterC-DLS I agree. Without the denominator, the units no longer cancel.

@PeterC-DLS PeterC-DLS modified the milestones: NXDL 2023.06, NXDL 2023.10 Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prjemian prjemian

Labels
bug
Projects
None yet
Milestone
NXDL 2023.10
Development

Successfully merging a pull request may close this issue.

NXxpcs: use a valid units type nexusformat/definitions
3 participants
@PeterC-DLS @prjemian @TLCFEM