Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make countrate_correction_lookup_table optional in NXmx? #1310

Closed
phyy-nx opened this issue Sep 6, 2023 · 1 comment · Fixed by #1312
Closed

Make countrate_correction_lookup_table optional in NXmx? #1310

phyy-nx opened this issue Sep 6, 2023 · 1 comment · Fixed by #1312

Comments

@phyy-nx
Copy link
Contributor

phyy-nx commented Sep 6, 2023

As pointed out to me by @biochem-fan, countrate_correction_lookup_table is not applicable to CCDs so it doesn't make sense to make it a required attribute. I suppose this similarly applies to countrate_correction_applied. These NXdetector fields were added as required to NXmx in #975.

@soph-dec
Copy link
Contributor

I think the fact that the countrate_correction_lookup_table is required was a simple oversight by me (in NXdetector, not specifying makes a field optional, while in NXmx, it defaults to required). It does not make much sense to have it required since countrate_correction_applied is optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants