Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML Schema says NX_CHAR but should be NX_UINT? #571

Closed
prjemian opened this issue Jun 11, 2017 · 1 comment
Closed

XML Schema says NX_CHAR but should be NX_UINT? #571

prjemian opened this issue Jun 11, 2017 · 1 comment
Labels
Milestone

Comments

@prjemian
Copy link
Contributor

In nxdl.xsd, dimensionsType, the data type of the rank attribute is NX_CHAR. Seems it should be NX_UINT. Will there be adverse consequences if this change is included in the next definitions release?

		<xs:attribute name="rank" type="nx:NX_CHAR">
			<xs:annotation>
				<xs:documentation>
					Rank (number of dimensions) of the data structure.  
					For example: ``a[5]`` has ``rank="1"`` while 
					``b[8,5,6,4]`` has ``rank="4"``.  
					See http://en.wikipedia.org/wiki/Rank_(computer_programming) 
					for more details.
				</xs:documentation>
			</xs:annotation>
		</xs:attribute>
@prjemian prjemian added the bug label Jun 11, 2017
@prjemian prjemian added this to the NeXus definitions 3.3 milestone Jun 11, 2017
@prjemian
Copy link
Contributor Author

Yes. It affects NXmx (and possibly others) directly where the rank is specified as a symbol

	<dimensions rank="dataRank">
		<dim index="1" value="np" />
		<dim index="2" value="i" />
		<dim index="3" value="j" />
		<dim index="4" value="k" required="false"/>
	</dimensions>

Best to leave this as NX_CHAR but add to the documentation.

@prjemian prjemian mentioned this issue Jun 21, 2017
prjemian added a commit that referenced this issue Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant