Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a make variable to define common python for #1072 #1071

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Use a make variable to define common python for #1072 #1071

merged 1 commit into from
Jun 14, 2022

Conversation

PeterC-DLS
Copy link
Contributor

No description provided.

@PeterC-DLS PeterC-DLS added this to the NXDL 2022.06 milestone Jun 13, 2022
@PeterC-DLS PeterC-DLS changed the title Use a make variable to define common python Use a make variable to define common python for #1072 Jun 13, 2022
woutdenolf
woutdenolf approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@woutdenolf woutdenolf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If python3 also works for virtual environment (pyenv, conda, ...) then I'm ok with it.

It's ok for pyenv and conda.

prjemian
prjemian approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@PeterC-DLS
Copy link
Contributor Author

PeterC-DLS commented Jun 14, 2022 •
edited
Loading

Yeah, I noticed that some distribution do not have a python executable at all but a python3 one. Closes #1072

@PeterC-DLS PeterC-DLS merged commit 22fab42 into main Jun 14, 2022
@PeterC-DLS PeterC-DLS deleted the use-defined-python branch June 14, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prjemian prjemian prjemian approved these changes

@woutdenolf woutdenolf woutdenolf approved these changes

Assignees
No one assigned
Labels
code camp
Projects
None yet
Milestone
NXDL 2022.06
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterC-DLS @prjemian @woutdenolf