NXbeam: clarify how beams can be in either sample or instrument groups #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation about cases where NXbeam is defined as a subgroup directly inside a NXinstruments group.
|
Update from code camp. Add this sentence: ", in which case it is recommended that the position of the beam is specified by an NXtransformations group, unless the beam is at the origin (which is the sample)." |
Add suggested change to NXbeam.nxdl.xml description according to what was discussed during code camp meetings.
|
Sentence Added! |
phyy-nx
approved these changes
Jun 21, 2023
phyy-nx
changed the title
newville
pushed a commit
to newville/definitions
that referenced
this pull request
Jun 22, 2023
nexusformat#1283) Add documentation about cases where NXbeam is defined as a subgroup directly inside a NXinstruments group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation about cases where NXbeam is defined as a subgroup directly inside a NXinstruments group.
Closes #1263