Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify NXdetector gain_setting and remove enumeration. #896

Merged
merged 8 commits into from
Jun 13, 2022
Merged

Clarify NXdetector gain_setting and remove enumeration. #896

merged 8 commits into from
Jun 13, 2022

Conversation

phyy-nx
Copy link
Contributor

@phyy-nx phyy-nx commented Mar 22, 2021 •
edited by prjemian
Loading

@phyy-nx phyy-nx added the NIAC should review The NIAC should review/discuss label Mar 22, 2021
@phyy-nx
Copy link
Contributor Author

phyy-nx commented Mar 22, 2021

Likely requires a NIAC vote

@prjemian prjemian added this to the NXDL 2021.10 milestone Mar 22, 2021
yayahjb
yayahjb approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@yayahjb yayahjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. -- Herbert

@yayahjb
Copy link
Contributor

yayahjb commented Mar 23, 2021

Would have merged if not for the need of NIAC approval. -- Herbert

@benajamin benajamin mentioned this pull request Feb 28, 2022
Closed
@phyy-nx
Copy link
Contributor Author

phyy-nx commented Mar 12, 2022

Ready for further review after addressing feedback from Spring NIAC 2022

@prjemian prjemian requested a review from benajamin June 13, 2022 14:43
prjemian
prjemian approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@prjemian prjemian mentioned this pull request Jun 13, 2022
Closed
benajamin
benajamin approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@benajamin benajamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Changing the whitespace makes it tricky to check for real changes, but I don't see any obvious problems.

@benajamin benajamin merged commit 5798a56 into main Jun 13, 2022
@benajamin benajamin deleted the gain_settings_fix branch June 13, 2022 14:53
@prjemian
Copy link
Contributor

For the future, change whitespace in new issue unless required (such as with documentation blocks).

@phyy-nx
Copy link
Contributor Author

phyy-nx commented Jun 13, 2022

Thanks for the cleanup and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterC-DLS PeterC-DLS PeterC-DLS approved these changes

@prjemian prjemian prjemian approved these changes

@yayahjb yayahjb yayahjb approved these changes

@benajamin benajamin benajamin approved these changes

Assignees
No one assigned
Labels
code camp NIAC should review The NIAC should review/discuss
Projects
None yet
Milestone
NXDL 2022.06
Development

Successfully merging this pull request may close these issues.

Clarify gain_setting in NXdetector
5 participants
@phyy-nx @yayahjb @prjemian @PeterC-DLS @benajamin