Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements.txt to automated build #902

Merged
merged 5 commits into from
Mar 23, 2021
Merged

Add requirements.txt to automated build #902

merged 5 commits into from
Mar 23, 2021

Conversation

FreddieAkeroyd
Copy link
Member

@FreddieAkeroyd FreddieAkeroyd commented Mar 23, 2021

This allows specification of items needed for python venv on ISIS doc build server

See #899

It is possible to use a requirements.txt from a conda environment.yml

name: test-env
dependencies:
  - python>=3.5
  - anaconda
  - pip
  - pip:
    - -r file:requirements.txt

@FreddieAkeroyd
Copy link
Member Author

have reduced requirements.txt to same 4 entries as environment.yml and it works fine

jenkins_build Outdated Show resolved Hide resolved
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of items in the requirements, many of which are probably required by a smaller number of packages we name here. pip will examine the requirements of each package named in this file. This list may need to be pruned later as the packages we actually need update their requirements. If it works now, we can defer the pruning actions to a later issue.

@FreddieAkeroyd
Copy link
Member Author

I pruned requirements.txt and it still seems to work on our local build server

Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants