Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build & publish documentation to gh-pages from GitHub Actions workflow #955

Merged
merged 17 commits into from
Feb 21, 2022

Conversation

prjemian
Copy link
Contributor

@prjemian
Copy link
Contributor Author

Note that until #950 is fixed (by PR #951) and merged into this branch, the Syntax Checks / CI are expected to fail here.

@prjemian
Copy link
Contributor Author

Let's disable the syntax-checks.yml workflow now to turn off the nuisance emails as they fail.

@prjemian
Copy link
Contributor Author

Actually, this PR needs #951 first.

@prjemian prjemian marked this pull request as draft December 10, 2021 20:19
@prjemian
Copy link
Contributor Author

Once the changes from #951 (which will fix the syntax checks) can be merged here, we can test the final publishing step. (Without those fixes, the newly-prepared docs are missing quite a bit content.) Only then would I consider this PR suitable for review.

@PeterC-DLS , @FreddieAkeroyd : That said, could either of you take a look at this before it is marked ready to review?

@prjemian
Copy link
Contributor Author

To see how this has been run, consult the Actions logs for the Publish Sphinx Docs to GitHub Pages workflow: https://github.com/nexusformat/definitions/actions/workflows/publish-sphinx.yml

@PeterC-DLS
Copy link
Contributor

Looks okay but checks failing strangely...

@prjemian
Copy link
Contributor Author

prjemian commented Dec 13, 2021 via email

@PeterC-DLS
Copy link
Contributor

@prjemian
Copy link
Contributor Author

Right. That error has been appearing lately and looks like a problem with pip. Not something NeXus can resolve.

@prjemian
Copy link
Contributor Author

related documentation to be adjusted:

(base) prjemian@zap:~/.../NeXus/definitions$ git grep /pdf/
manual/source/design.rst:.. [#] https://manual.nexusformat.org/pdf/NeXusIntern.pdf
manual/source/introduction-napi.rst:see the `NeXus Internals manual <https://manual.nexusformat.org/pdf/NeXusIntern.pdf>`_, copied from the NeXus code repository.
nxdl.xsd:                                                       http://manual.nexusformat.org/pdf/NeXusIntern.pdf

@prjemian
Copy link
Contributor Author

@PeterC-DLS - Now I recall, the workflow failures involving pip were due to the incorrect instructions in /environment.yml that were fixed in #951 (by using a different YAML file for the GH workflow):

- pip:
- -r file:requirements.txt

@prjemian
Copy link
Contributor Author

Is the /environment.yml file necessary now?

@prjemian prjemian marked this pull request as ready for review December 13, 2021 15:29
@prjemian
Copy link
Contributor Author

Now that #951 is merged into this branch, the workflow failures (noted above) are resolved.

@prjemian
Copy link
Contributor Author

@FreddieAkeroyd , @PeterC-DLS : Please review.

@prjemian prjemian added the telco label Dec 13, 2021
@prjemian
Copy link
Contributor Author

@FreddieAkeroyd Can you review this PR?

@prjemian
Copy link
Contributor Author

prjemian commented Feb 5, 2022

I will merge this PR 2022-02-07 unless there are objections.

@prjemian prjemian merged commit 4e48fcf into main Feb 21, 2022
@prjemian prjemian deleted the 953-publish-gh-pages branch February 21, 2022 18:39
@FreddieAkeroyd
Copy link
Member

Sorry @prjemian my GH notifications are all over the place. Should the actions be publishing to https://github.com/nexusformat/definitions/tree/gh-pages or do they publish elsewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish documentation from GitHub Actions workflow
3 participants