Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/sex determination #97

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Bug/sex determination #97

merged 5 commits into from
Jul 31, 2024

Conversation

nvnieuwk
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • Parameters Documentation is updated with nf-core schema docs --format markdown --output docs/parameters.md --force
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nvnieuwk
Copy link
Member Author

Fixes #95

@nvnieuwk nvnieuwk requested a review from mvheetve July 30, 2024 13:15
mvheetve
mvheetve approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@mvheetve mvheetve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okidoki!

@nvnieuwk nvnieuwk merged commit 08a6fd4 into dev Jul 31, 2024
37 of 38 checks passed
@nvnieuwk nvnieuwk deleted the bug/sex-determination branch July 31, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvheetve mvheetve mvheetve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvnieuwk @mvheetve