Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ben made me do this (+ nf-schema migration) #98

Merged
merged 11 commits into from
Sep 3, 2024
Merged

Ben made me do this (+ nf-schema migration) #98

merged 11 commits into from
Sep 3, 2024

Conversation

nvnieuwk
Copy link
Member

@nvnieuwk nvnieuwk commented Sep 3, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • Parameters Documentation is updated with nf-core schema docs --format markdown --output docs/parameters.md --force
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@matthdsm
Copy link
Member

matthdsm commented Sep 3, 2024

Scherm­afbeelding 2024-09-03 om 15 13 49
LOL

matthdsm
matthdsm approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@matthdsm matthdsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvnieuwk
Copy link
Member Author

nvnieuwk commented Sep 3, 2024

Linting fixes will follow in another PR

@nvnieuwk nvnieuwk merged commit 46a6281 into dev Sep 3, 2024
36 of 38 checks passed
@nvnieuwk nvnieuwk deleted the ben-made-me-do-this branch September 3, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthdsm matthdsm matthdsm approved these changes

@mvheetve mvheetve Awaiting requested review from mvheetve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvnieuwk @matthdsm