Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social preview image #80

Merged
merged 2 commits into from
Feb 12, 2020
Merged

Add social preview image #80

merged 2 commits into from
Feb 12, 2020

Conversation

maxulysse
Copy link
Member

  • Add social preview image

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/atacseq branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/atacseq/tree/master/.github/CONTRIBUTING.md

@maxulysse maxulysse requested a review from a team February 11, 2020 14:44
@drpatelh
Copy link
Member

What happened to the fancy custom ones you created for me? Cant see them anymore in my Slack history 😓

@maxulysse
Copy link
Member Author

You meant the logos?
As we're not paying for Slack, so history is limited.
Currently, as there is no pipeline specific logo, this is the social preview image.
When there is logo, we can talk about an updated social preview

@drpatelh
Copy link
Member

Tests are failing due to some weird channel error with the latest version of Nextflow. Quite an uncontroversial change so Ill merge and fix downstream. Thanks @maxulysse 😎

@drpatelh drpatelh merged commit 34ed69b into nf-core:dev Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants