v1.0.0 release #18
Merged
v1.0.0 release #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulling upstream 1.0.0 merge
…ts; starting v1.1.0
Important! Template update for nf-core/tools v2.10
merging template v2.1 request
|
alyssa-ab
reviewed
Nov 28, 2023
There was a problem hiding this comment.
Files changed on this PR look good. The only issue I see is that the callingcards.nf workflow still has the INPUT_CHECK subworkflow and the related components are floating around in your repository. (callingcards_mammals.nf does have nf-validation, so that workflow is good)
|
the latest-everything CI check transiently fails. I have been unable to re-create this error on my local slurm cluster |
sateeshperi
reviewed
Dec 9, 2023
| @@ -1,3 +1,4 @@ | |||
| name: callingcardstools | |||
There was a problem hiding this comment.
shouldn't it be the name of the module here rather than the pipeline?
There was a problem hiding this comment.
This was per @maxulysse . From him, my understanding that is the name of the environment. Since I am using the same environment for all of the callingcardstools modules, by using the same name in each, it means that if the env exists it won't be downloaded again by a subsequent module.
There was a problem hiding this comment.
if @maxulysse says so I'm ok with that
sateeshperi
approved these changes
Dec 15, 2023
Important! Template update for nf-core/tools v2.11
merging commit with template update 2.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing @FriederikeHanssen's review requests; updating all modules to nf-core modules current state