Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering macs2 files without peaks #268

Merged
merged 5 commits into from
Apr 20, 2022

Conversation

JoseEspinosa
Copy link
Member

@JoseEspinosa JoseEspinosa commented Mar 30, 2022

As explained in #128 when macs2 files have any peak inside an exception is raised.

Closes #128

PR checklist

  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • CHANGELOG.md is updated

@JoseEspinosa
Copy link
Member Author

Have drafted this PR by the moment, although the data in issue #128 is no longer available, I guess you also don't have it @drpatelh 🙄
If not we may need in slack for it

@drpatelh
Copy link
Member

Yep, maybe we ask Pablo on Slack. Wonder if we can sub-sample the test data quite heavily to reproduce? 🤔

@JoseEspinosa JoseEspinosa marked this pull request as ready for review April 19, 2022 19:41
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! You found a real dataset to test with?

@JoseEspinosa
Copy link
Member Author

I mixed a file from Pablo with our test-dataset but I think it might be safer than someone else give it a try

@JoseEspinosa JoseEspinosa merged commit 32698df into nf-core:dev Apr 20, 2022
@JoseEspinosa JoseEspinosa deleted the peaks_#128 branch April 20, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants