Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code after nf-validation adoption #368

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Update code after nf-validation adoption #368

merged 6 commits into from
Oct 17, 2023

Conversation

JoseEspinosa
Copy link
Member

@JoseEspinosa JoseEspinosa commented Oct 16, 2023 •
edited by bjlang
Loading

Closes #367

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/chipseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 60ecfe4

+| ✅ 159 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowChipseq.groovy: Optionally add in-text citation tools to this list.

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-17 08:41:22

@JoseEspinosa JoseEspinosa marked this pull request as ready for review October 17, 2023 08:09
bjlang
bjlang approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@bjlang bjlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JoseEspinosa JoseEspinosa merged commit 42b50c3 into nf-core:dev Oct 17, 2023
11 checks passed
@JoseEspinosa JoseEspinosa self-assigned this Oct 17, 2023
@JoseEspinosa JoseEspinosa mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjlang bjlang bjlang approved these changes

Assignees

@JoseEspinosa JoseEspinosa

Labels
None yet
Projects
Hackathon: November 2023
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoseEspinosa @bjlang