Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module updates to fit with recent registry changes #129

Merged
merged 3 commits into from
May 11, 2023
Merged

Module updates to fit with recent registry changes #129

merged 3 commits into from
May 11, 2023

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented May 11, 2023 •
edited
Loading

Now all the modules have been updated, re-enable the registry settings (with fix borrowed from nf-core/rnaseq#1021), and update all the modules.

I also added a CHANGELOG update missing in the last PR.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented May 11, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 0da403a

+| ✅ 160 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-11 15:51:48

@pinin4fjords
Copy link
Member Author

Thanks @maxulysse @adamrtalbot !

@pinin4fjords pinin4fjords merged commit a7522f3 into nf-core:dev May 11, 2023
@pinin4fjords pinin4fjords deleted the container_repos_fix branch May 11, 2023 16:09
@pinin4fjords pinin4fjords added this to the 1.3.0 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrtalbot adamrtalbot adamrtalbot approved these changes

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pinin4fjords @maxulysse @adamrtalbot