Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set conda.enabled=true to fix Conda testing #2306

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Oct 14, 2022

This is my proposal to address conda testing failures, with reference to nextflow-io/nextflow#3073.

Motivate by failure discussed in https://nfcore.slack.com/archives/CJRH30T6V/p1665736973295039, #2167.

In summary, the Conda profile is no longer driving Conda environment creation and usage, which was noted previously, so I think we just need to set this param explicitly.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@pinin4fjords pinin4fjords requested a review from a team October 14, 2022 10:44
@pinin4fjords pinin4fjords changed the title set conda.enabled=true for Conda set conda.enabled=true for Conda to fix Conda testing Oct 14, 2022
@pinin4fjords pinin4fjords changed the title set conda.enabled=true for Conda to fix Conda testing set conda.enabled=true to fix Conda testing Oct 14, 2022
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would like a sceond pair of 👀 : , this also needs to be updated in the nf-core pipeline template if you're up for that @pinin4fjords ? (in the nextflow.config iIIRC

@grst
Copy link
Member

grst commented Oct 14, 2022

I'm a bit out of the loop, but doesn't this make the params.enable_conda obsolete?

@JoseEspinosa
Copy link
Member

Yep was about to say the same

@jfy133
Copy link
Member

jfy133 commented Oct 14, 2022

Would we not need it still for backwards compatibility for people not yet on 22.10?

@SPPearce SPPearce merged commit 1e3cdae into master Oct 14, 2022
@pinin4fjords pinin4fjords deleted the set_conda_enabled branch October 14, 2022 15:05
@edmundmiller
Copy link
Contributor

Should we have added a check for the nextflow version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants