-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor updates to biscuit modules #2656
Conversation
Note that |
Having the bam files in two output channels would be the first time ever in modules ! Let me ask on Slack what the other maintainers think about this |
Ok, fixed those issues. Thanks for your input and please let me know if there is anything else I can do! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you !
PR checklist
versions.yml
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
Minor updates to these modules:
biscuit
andsamtools
set -o pipefail
to all commands involving pipes--write-index
option toalign
align
andbiscuitblaster
(indexed_bam) containing both .bam and .bai files