Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to biscuit modules #2656

Merged
merged 15 commits into from
Dec 19, 2022
Merged

Minor updates to biscuit modules #2656

merged 15 commits into from
Dec 19, 2022

Conversation

njspix
Copy link
Contributor

@njspix njspix commented Dec 13, 2022

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

Minor updates to these modules:

  • version bumps for biscuit and samtools
  • multi-package container update (corresponding)
  • add set -o pipefail to all commands involving pipes
  • add --write-index option to align
  • add an output channel to both align and biscuitblaster (indexed_bam) containing both .bam and .bai files

@njspix
Copy link
Contributor Author

njspix commented Dec 13, 2022

Note that biscuitblaster tests are expected to fail until nf-core/test-datasets#715 is merged. Incorrect read naming makes samblaster puke, but I wasn't catching this before because set -o pipefail wasn't set...

@njspix njspix requested a review from drpatelh December 13, 2022 20:22
@njspix njspix marked this pull request as ready for review December 13, 2022 20:30
@muffato
Copy link
Member

muffato commented Dec 18, 2022

add an output channel to both align and biscuitblaster (indexed_bam) containing both .bam and .bai files

Having the bam files in two output channels would be the first time ever in modules ! Let me ask on Slack what the other maintainers think about this

modules/nf-core/biscuit/align/main.nf Outdated Show resolved Hide resolved
modules/nf-core/biscuit/biscuitblaster/main.nf Outdated Show resolved Hide resolved
modules/nf-core/biscuit/epiread/main.nf Outdated Show resolved Hide resolved
modules/nf-core/biscuit/mergecg/main.nf Outdated Show resolved Hide resolved
modules/nf-core/biscuit/pileup/main.nf Outdated Show resolved Hide resolved
modules/nf-core/biscuit/vcf2bed/main.nf Outdated Show resolved Hide resolved
@njspix
Copy link
Contributor Author

njspix commented Dec 19, 2022

Ok, fixed those issues. Thanks for your input and please let me know if there is anything else I can do!

Copy link
Member

@muffato muffato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you !

@njspix njspix merged commit 014209c into nf-core:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants