Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output channel modification star #3350

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Output channel modification star #3350

merged 2 commits into from
Apr 28, 2023

Conversation

Lucpen
Copy link
Contributor

@Lucpen Lucpen commented Apr 28, 2023 •
edited
Loading

PR checklist

Closes #XXX

  • I have added two output channel, one containing tab_junction file and one containing ReadsPerGene.tab, it is more logical to have this separate even if they are both .tab because they will be used for different purposes.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@Lucpen Lucpen added enhancement New feature or request Ready for Review labels Apr 28, 2023
@Lucpen Lucpen added this pull request to the merge queue Apr 28, 2023
Merged via the queue into master with commit 140d5a0 Apr 28, 2023
jvfe added a commit to jvfe/modules that referenced this pull request May 2, 2023
@jvfe
Merge branch 'master' into islandpath
95cb7c8 
* master: (97 commits)
  Use long form docker.io address for Ubuntu (nf-core#3358)
  Default registry to quay.io (nf-core#3344)
  Sbwf impute glimpse2 (nf-core#3349)
  added cellranger vdj/mkvdjref modules, with module test for vdj (nf-core#3033)
  Add space to fix singularity download error on shinyngs modules (nf-core#3351)
  Output channel modification star (nf-core#3350)
  fix corrected typo in output (nf-core#3337)
  give execution permissions to dumpsoftwareversions.py (nf-core#3347)
  fix meta.ymls for dumpsoftware and multiqc (nf-core#3345)
  Fixing failing subworkflow tests (nf-core#3343)
  remove imputeme module since it is evidently no longer supported (nf-core#3223)
  Update path for yaml-schema json (nf-core#3340)
  New module MetaPhlAn4 (nf-core#3298)
  Update ALL bcftools modules (nf-core#3339)
  update docker and singularity version of p7zip (nf-core#3338)
  update sratools/fasterqdump to handle 10X data (nf-core#3336)
  Make MAD plots optional in shinyngs (nf-core#3334)
  reset tools in CI to released version (nf-core#3335)
  new module wisecondorx/gender (nf-core#3333)
  Bump shinyngs modules (nf-core#3323)
  ...
jvfe added a commit to jvfe/modules that referenced this pull request May 2, 2023
@jvfe
Merge branch 'master' into update-panaroo/run
0e077da 
* master: (120 commits)
  Use long form docker.io address for Ubuntu (nf-core#3358)
  Default registry to quay.io (nf-core#3344)
  Sbwf impute glimpse2 (nf-core#3349)
  added cellranger vdj/mkvdjref modules, with module test for vdj (nf-core#3033)
  Add space to fix singularity download error on shinyngs modules (nf-core#3351)
  Output channel modification star (nf-core#3350)
  fix corrected typo in output (nf-core#3337)
  give execution permissions to dumpsoftwareversions.py (nf-core#3347)
  fix meta.ymls for dumpsoftware and multiqc (nf-core#3345)
  Fixing failing subworkflow tests (nf-core#3343)
  remove imputeme module since it is evidently no longer supported (nf-core#3223)
  Update path for yaml-schema json (nf-core#3340)
  New module MetaPhlAn4 (nf-core#3298)
  Update ALL bcftools modules (nf-core#3339)
  update docker and singularity version of p7zip (nf-core#3338)
  update sratools/fasterqdump to handle 10X data (nf-core#3336)
  Make MAD plots optional in shinyngs (nf-core#3334)
  reset tools in CI to released version (nf-core#3335)
  new module wisecondorx/gender (nf-core#3333)
  Bump shinyngs modules (nf-core#3323)
  ...
@maxulysse maxulysse deleted the output_channel_modification_STAR branch June 12, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lucpen @mashehu