Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing/wrong SENTIEON_DEDUP stub output #4632

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

alkc
Copy link
Contributor

@alkc alkc commented Dec 20, 2023

fixes nf-core/raredisease#462

Description

The stub files created by SENTIEON_DEDUP do not match that of the main process.

This update fixes that by adding the missing files and modifying the stub code so that bam/bai or cram/crai files are created depending on the process input, instead of only creating a cram and crai by default.

Example

Discovered when trying to do a stub run in in the raredisease pipeline:

ERROR ~ Error executing process > 'NFCORE_RAREDISEASE:RAREDISEASE:ALIGN:ALIGN_SENTIEON:SENTIEON_DEDUP (hugelymodelbat)'

Caused by:
  Missing output file(s) `*.bai` expected by process `NFCORE_RAREDISEASE:RAREDISEASE:ALIGN:ALIGN_SENTIEON:SENTIEON_DEDUP (hugelymodelbat)` (note: input files are not included in the
efault matching set)

Command executed:

  touch hugelymodelbat_dedup.cram
  touch hugelymodelbat_dedup.cram.crai
  touch hugelymodelbat_dedup.metrics
  touch hugelymodelbat_dedup.score

  cat <<-END_VERSIONS > versions.yml
  "NFCORE_RAREDISEASE:RAREDISEASE:ALIGN:ALIGN_SENTIEON:SENTIEON_DEDUP":
      sentieon: $(echo $(sentieon driver --version 2>&1) | sed -e "s/sentieon-genomics-//g")
  END_VERSIONS

Command exit status:
  0

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

The files output by the process stub now match that of the main process.

The stub also creates a bam/cram bai/crai file depending on the process
input, instead of just creating a cram and crai by default.
@alkc alkc requested a review from asp8200 as a code owner December 20, 2023 13:48
@alkc
Copy link
Contributor Author

alkc commented Dec 20, 2023

There. The PR is ready for review. The first commit accidentally removed the bam/cram file from the stub output.

I've confirmed in the raredisease pipeline that the stub works as it should now.

@maxulysse
Copy link
Member

Tests are failing for now, cause I need to restart the license server

@maxulysse maxulysse mentioned this pull request Jan 24, 2024
3 tasks
@maxulysse maxulysse merged commit 740119f into nf-core:master Jan 24, 2024
8 of 10 checks passed
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
* Fix missing/wrong sentieon dedup stub output files

The files output by the process stub now match that of the main process.

The stub also creates a bam/cram bai/crai file depending on the process
input, instead of just creating a cram and crai by default.

* Create bam/crai stub file

* Fix extra quotation mark x_x

---------

Co-authored-by: Ramprasad Neethiraj <[email protected]>
Co-authored-by: Anders Jemt <[email protected]>
Co-authored-by: Maxime U Garcia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid stub output in SENTIEON_DEDUP crashes sentieon stub run
5 participants