-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing/wrong SENTIEON_DEDUP
stub output
#4632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The files output by the process stub now match that of the main process. The stub also creates a bam/cram bai/crai file depending on the process input, instead of just creating a cram and crai by default.
alkc
force-pushed
the
fix-sentieon-dedup-stub
branch
from
December 20, 2023 14:02
a9bd056
to
1d97ce1
Compare
There. The PR is ready for review. The first commit accidentally removed the bam/cram file from the stub output. I've confirmed in the raredisease pipeline that the stub works as it should now. |
SPPearce
approved these changes
Dec 21, 2023
Tests are failing for now, cause I need to restart the license server |
11 tasks
3 tasks
jennylsmith
pushed a commit
to RSC-RP/modules
that referenced
this pull request
Mar 20, 2024
* Fix missing/wrong sentieon dedup stub output files The files output by the process stub now match that of the main process. The stub also creates a bam/cram bai/crai file depending on the process input, instead of just creating a cram and crai by default. * Create bam/crai stub file * Fix extra quotation mark x_x --------- Co-authored-by: Ramprasad Neethiraj <[email protected]> Co-authored-by: Anders Jemt <[email protected]> Co-authored-by: Maxime U Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes nf-core/raredisease#462
Description
The stub files created by
SENTIEON_DEDUP
do not match that of the main process.This update fixes that by adding the missing files and modifying the stub code so that bam/bai or cram/crai files are created depending on the process input, instead of only creating a cram and crai by default.
Example
Discovered when trying to do a stub run in in the raredisease pipeline:
PR checklist
versions.yml
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware