Updated test data base path batch 1 #6048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GallVp
requested review from
JoseEspinosa,
drpatelh,
maxulysse,
DLBPointon,
spficklin,
jfy133,
mjamy and
a team
as code owners
SPPearce
reviewed
Jul 29, 2024
| @@ -213,8 +213,8 @@ nextflow_process { | |||
| input[0] = [ | |||
| [ id:'test', single_end:false ], // meta map | |||
| [ | |||
| file(params.test_data['homo_sapiens']['illumina']['test_1_fastq_gz'], checkIfExists: true), | |||
| file(params.test_data['homo_sapiens']['illumina']['test_2_fastq_gz'], checkIfExists: true) | |||
| file(params.modules_testdata_base_path + 'genomics/homo_sapiens/illumina/fastq/test_1.fastq.gz', checkIfExists: true) | |||
There was a problem hiding this comment.
Hmm, this one seems to have lost the comma at the end.
There was a problem hiding this comment.
Good catch! I'll try to figure out how it happened.
|
As you've noticed, there are a bunch of modules which currently fail the tests for various reasons |
SPPearce
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #XXX
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda