Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing homer outputs #97

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Missing homer outputs #97

merged 2 commits into from
Jan 19, 2023

Conversation

edmundmiller
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/nascent branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@edmundmiller edmundmiller added this to the v2.1.0 milestone Nov 28, 2022
@edmundmiller edmundmiller self-assigned this Nov 28, 2022
@edmundmiller edmundmiller added the bug Something isn't working label Nov 28, 2022
@github-actions
Copy link

github-actions bot commented Nov 28, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 71c8cf7

+| ✅ 154 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   8 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Add full-sized test dataset and amend the paragraph below if applicable
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or directly in repositories, e.g. SRA)
  • pipeline_todos - TODO string in test_full.config: Give any required params for the test so that command line flags are not needed
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • schema_description - No description provided in schema for parameter: assay_type
  • schema_description - No description provided in schema for parameter: skip_grohmm

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html

✅ Tests passed:

Run details

  • nf-core/tools version 2.6
  • Run at 2022-11-28 17:01:43

@edmundmiller edmundmiller merged commit 11956d4 into dev Jan 19, 2023
@edmundmiller edmundmiller deleted the missing_homer_outputs branch January 19, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees

@edmundmiller edmundmiller

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@edmundmiller @FriederikeHanssen