Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel bychr #18

Merged
merged 28 commits into from
Mar 22, 2024
Merged

Panel bychr #18

merged 28 commits into from
Mar 22, 2024

Conversation

LouisLeNezet
Copy link
Collaborator

@LouisLeNezet LouisLeNezet commented Mar 20, 2024

Separate panel by chr do the same for the map file.
Update all modules

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/phaseimpute branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@LouisLeNezet LouisLeNezet self-assigned this Mar 20, 2024
@LouisLeNezet
Copy link
Collaborator Author

Fix #11

Copy link
Collaborator

@atrigila atrigila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🎉 I left some suggestions for further improvement :)
In terms of PRs, I recommend considering the size and focus of future contributions. An example would be separating chromosome handling and the full size dataset changes into distinct PRs for more comprehensive testing and review.

Lastly, it would be useful if these changes were accompanied by updates to the documentation so that it helps with reading and understanding of the changes implemented :)

CHANGELOG.md Outdated Show resolved Hide resolved
assets/panel.csv Outdated Show resolved Hide resolved
assets/schema_input_panel.json Outdated Show resolved Hide resolved
assets/schema_input_panel.json Outdated Show resolved Hide resolved
assets/schema_input_panel.json Outdated Show resolved Hide resolved
modules.json Outdated Show resolved Hide resolved
tests/csv/panel_full.csv Show resolved Hide resolved
@LouisLeNezet LouisLeNezet linked an issue Mar 21, 2024 that may be closed by this pull request
@LouisLeNezet LouisLeNezet linked an issue Mar 21, 2024 that may be closed by this pull request
@LouisLeNezet LouisLeNezet mentioned this pull request Mar 21, 2024
Copy link
Collaborator

@atrigila atrigila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only fix I see is to remove the anyOf from schema_input_region.json. Other than that, in principle, LGTM.

subworkflows/local/compute_gl/main.nf Show resolved Hide resolved
assets/panel.csv Show resolved Hide resolved
assets/schema_input_region.json Outdated Show resolved Hide resolved
conf/modules.config Show resolved Hide resolved
@LouisLeNezet LouisLeNezet merged commit cb62a8e into nf-core:dev Mar 22, 2024
6 checks passed
atrigila pushed a commit that referenced this pull request Mar 27, 2024
@LouisLeNezet LouisLeNezet added this to the v0.99.0 milestone Apr 24, 2024
@LouisLeNezet LouisLeNezet deleted the panel_bychr branch May 30, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference panel should accept a CSV
2 participants