Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to nf-validation for parameter and samplesheet validation #386

Merged
merged 5 commits into from
Jul 26, 2023
Merged

switch to nf-validation for parameter and samplesheet validation #386

merged 5 commits into from
Jul 26, 2023

Conversation

ramprasadn
Copy link
Collaborator

@ramprasadn ramprasadn commented Jul 24, 2023 •
edited
Loading

PR checklist

Use nf-validation plugin for parameter and samplesheet validation

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jul 24, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d671af6

+| ✅ 151 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-07-26 13:55:06

@ramprasadn ramprasadn changed the title switch to validation switch to nf-validation for parameter and samplesheet validation Jul 24, 2023
@ramprasadn ramprasadn marked this pull request as ready for review July 24, 2023 20:32
nvnieuwk
nvnieuwk approved these changes Jul 26, 2023
View reviewed changes
Copy link

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! How did the implementation go? Anything that could have been made easier? :p

@ramprasadn
Copy link
Collaborator Author

Fairly straightforward 😅
Only thing I found a bit confusing was navigating the website, but I noticed that was already raised on slack 😜

@ramprasadn ramprasadn merged commit 78b50c1 into nf-core:dev Jul 26, 2023
8 checks passed
@nvnieuwk
Copy link

Fairly straightforward sweat_smile Only thing I found a bit confusing was navigating the website, but I noticed that was already raised on slack stuck_out_tongue_winking_eye

Awesome thanks! Yes Phil fixed that indeed

@ramprasadn ramprasadn deleted the bumpversion branch July 26, 2023 14:21
@ramprasadn ramprasadn mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvnieuwk nvnieuwk nvnieuwk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramprasadn @nvnieuwk